PerishLab/plumb
1
0
Fork 0
Code Issues 11 Pull requests 22 Projects Releases Packages 1 Wiki Activity Actions

Let a landed message say its subject once #330

Open
PerishFire wants to merge 1 commit from task/a-landed-message-says-it-once into main
pull from: task/a-landed-message-says-it-once
merge into: PerishLab:main
Conversation 0 Commits 1 Files changed 2 +11 -4
PerishFire commented 2026-08-18 13:43:04 +00:00
Owner
Copy link

plumb land derived the candidate title from %s and its body from %B, and %B is the whole message, subject included. Every landed commit opened with its own subject twice — as the subject, then again as the first body line. Every commit on this line carries it, back past v0.26.0.

The body still comes from %B: a branch of several commits needs each subject inside the combined body. Only the first is redundant, and only because the title stands directly above it — so the derived body drops a leading copy of the title and nothing else. A --body supplied by the caller is left alone.

Verified by landing this commit and reading what arrives on main; the message is composed inside a private flow no test target can reach.

`plumb land` derived the candidate title from `%s` and its body from `%B`, and `%B` is the whole message, subject included. Every landed commit opened with its own subject twice — as the subject, then again as the first body line. Every commit on this line carries it, back past v0.26.0. The body still comes from `%B`: a branch of several commits needs each subject inside the combined body. Only the first is redundant, and only because the title stands directly above it — so the derived body drops a leading copy of the title and nothing else. A `--body` supplied by the caller is left alone. Verified by landing this commit and reading what arrives on main; the message is composed inside a private flow no test target can reach.
Let a landed message say its subject once
All checks were successful
guard / guard (pull_request) Successful in 2m57s
Details
594a0d8a30 
`plumb land` derived the candidate's title from `%s` and its body from `%B`,
and `%B` is the whole message, subject included. Every landed commit therefore
opened with its own subject twice — once as the subject, once as the first line
of the body. Every commit on this line carries it, back past v0.26.0.

The body still comes from `%B`, because a branch of several commits needs each
subject inside the combined body; only the first one is redundant, and only
because the title is standing directly above it. So the derived body drops a
leading copy of the title and nothing else. A body supplied with `--body` is
left alone: that text is what the caller asked for.

Verified by landing this commit and reading what arrived on main, since the
message is composed inside a private flow that no test target can reach.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
All checks were successful
guard / guard (pull_request) Successful in 2m57s
Details
This pull request has changes conflicting with the target branch.
  • crates/lib/src/forgejo/land/flow.rs
  • plumb.toml
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin task/a-landed-message-says-it-once:task/a-landed-message-says-it-once
git switch task/a-landed-message-says-it-once
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
PerishLab/plumb!330
No description provided.